Fix missing entires when searching in the file browser#8320
Draft
sakertooth wants to merge 2 commits into
Draft
Conversation
messmerd
reviewed
Apr 2, 2026
bratpeki
reviewed
May 4, 2026
| emit finished(); | ||
| } | ||
|
|
||
| bool FileSearchJob::validEntry(QString entry, QStringList tokens, QStringList extensions) |
Member
There was a problem hiding this comment.
Suggested change
| bool FileSearchJob::validEntry(QString entry, QStringList tokens, QStringList extensions) | |
| bool FileSearchJob::validEntry(const QString& entry, const QStringList& tokens, const QStringList& extensions) |
bratpeki
reviewed
May 4, 2026
|
|
||
| private: | ||
| void runSearch(Task task); | ||
| bool validEntry(QString entry, QStringList tokens, QStringList extensions); |
Member
There was a problem hiding this comment.
Suggested change
| bool validEntry(QString entry, QStringList tokens, QStringList extensions); | |
| bool validEntry(const QString& entry, const QStringList& tokens, const QStringList& extensions); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some bugs with the search.
Changes:
FileSearchJob::Taskhas been removed).Future:
There were a couple of bugs I ran into while writing this PR. One of them I already reported on the tracker (see #8319). There is also another subtle issue where in the favorite browser, if you have two entries "folder_a/folder_b" and "folder_b" (which is in "folder_a"), duplicate search results will appear. Instead, "folder_b" should only be searched recursively once. This is something I might fix in here later or another PR (or maybe because of performance reasons I'll just leave it for now).