Fix piano roll opening with minimum height#8293
Closed
extern-stat wants to merge 1 commit into
Closed
Conversation
Member
|
Haven't tested this yet but have you looked at #8387? It seems to address the same bug but maybe does it in a cleaner way? |
Contributor
|
Oh, forgot this was a thing. This "accidentally" fixes the bug by overriding closeEvent, which would normally hide the widget when |
Contributor
Author
|
Superseded by #8387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8292 by handling and ignoring
Editor::closeEvent. I'm not sure if this is the best way to fix this bug, but it does fix the issue.