Exempt special satellites from the uname uniqueness check - #510
Open
mateo-moon wants to merge 1 commit into
Open
Exempt special satellites from the uname uniqueness check#510mateo-moon wants to merge 1 commit into
mateo-moon wants to merge 1 commit into
Conversation
This was referenced Jul 20, 2026
Since the uname map was introduced, only the first special satellite (e.g. EBS_TARGET) can authenticate: special satellites run within the controller's process, so they all report the controller's uname and every one after the first is de-authenticated with DUPLICATE_UNAME. This makes multi-AZ native EBS setups impossible to bootstrap. Special satellites never take part in DRBD, so the uname map (mapping DRBD peer unames to node names) does not apply to them. Skip the map update and the uniqueness check for special node types, mirroring the existing isSpecial() exemption for the node-name-mismatch info message in the same class. Fixes LINBIT#505
mateo-moon
force-pushed
the
fix/special-satellite-duplicate-uname
branch
from
July 20, 2026 23:43
c2f2887 to
43ee12a
Compare
Author
|
E2E-validated live on a 3-AZ Kubernetes cluster (arm64/Nitro, v1.34.1 base + all four of our EBS fix PRs): full validation report in #506 (comment) (latest comment). Highlights relevant to this PR are listed there; the four fixes together make native EBS work end-to-end on latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #505.
Problem
Since the uname map was introduced (v1.31.1), only the first special satellite (e.g.
EBS_TARGET) can authenticate. Special satellites run within the controller's process, soCtrlAuthreports the controller's uname (LinStor.getHostName()) for all of them, andupdateUnameMap()de-authenticates every one after the first withDUPLICATE_UNAME. This makes the documented multi-AZ native-EBS setup (one EBS target per AZ) impossible to bootstrap on any release ≥ 1.31.1. Details in #505.Fix
Skip the uname-map update and the uniqueness check for special node types. Special satellites never take part in DRBD, so the uname map — whose purpose is mapping DRBD peer unames to node names for replication-state reporting — does not apply to them. This mirrors the existing
isSpecial()exemption for the node-name-mismatch info message a few lines below in the same class.Testing
:controller:compileJava+:controller:checkstyleMainclean (no new warnings).NodeUnameso the map check passes lets all three EBS targets connect and (on a version unaffected by Controller never dispatches resources to EBS_TARGET special satellites on v1.33.3/v1.34.1 (works on v1.30.4) — native EBS volumes never created #506) serve volumes correctly — confirming nothing downstream depends on distinct unames for special satellites.create-ebs-targetnodes all reaching Online without workarounds) planned via cherry-pick onto a working EBS baseline, as the EBS path on master is currently blocked by Controller never dispatches resources to EBS_TARGET special satellites on v1.33.3/v1.34.1 (works on v1.30.4) — native EBS volumes never created #506. Happy to report results here.