Skip to content

GH-119: [DEPARTMENT FLOW] Fix response for dates without departments#120

Merged
ChanukaUOJ merged 5 commits into
LDFLK:mainfrom
zaeema-n:fix-sankey-missing-depts
Jul 8, 2026
Merged

GH-119: [DEPARTMENT FLOW] Fix response for dates without departments#120
ChanukaUOJ merged 5 commits into
LDFLK:mainfrom
zaeema-n:fix-sankey-missing-depts

Conversation

@zaeema-n

@zaeema-n zaeema-n commented Jul 8, 2026

Copy link
Copy Markdown
Member

This pr closes #119

@zaeema-n zaeema-n requested a review from ChanukaUOJ July 8, 2026 11:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the maximum number of dates for the cabinet flow endpoint from 3 to 10 and implements bridging logic to skip dates with no data or errors. It updates the API contract, the core service logic in organisation_service.py to use chart slot indices for nodes and links, and adds comprehensive unit tests to verify the bridging behavior. I have no feedback to provide as the implementation is clean and well-tested.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ChanukaUOJ ChanukaUOJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChanukaUOJ ChanukaUOJ merged commit 3efdcc8 into LDFLK:main Jul 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DEPARTMENT FLOW] Fix response for dates without departments

2 participants