fix(helpers) KONG_PORT_MAPS value for tls overrideServiceTarget port - #1091
Open
mithunkrb wants to merge 1 commit into
Open
fix(helpers) KONG_PORT_MAPS value for tls overrideServiceTarget port#1091mithunkrb wants to merge 1 commit into
mithunkrb wants to merge 1 commit into
Conversation
pmalek
reviewed
Oct 9, 2024
pmalek
left a comment
pmalek
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution. Please run make test.golden.update to update golden tests manifests for this. Additionally please add a changelog entry for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently KONG_PORT_MAPS uses the acutal tls serviceTargetPort even if overrideServiceTarget port is specified. This PR addresses the same, it uses tls overrideServiceTarget value when overrideServiceTarget is given.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.