Skip to content

Add readBuffer coverage for invalid enums below COLOR_ATTACHMENT0 #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 2 commits into from
Apr 17, 2026
Merged

Add readBuffer coverage for invalid enums below COLOR_ATTACHMENT0 #3771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d4fafd
Add readBuffer coverage for invalid enums below COLOR_ATTACHMENT0
blackfrog638 Apr 16, 2026
879bd1f
Apply suggestions from code review
kainino0x Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/tests/conformance2/renderbuffers/readbuffer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,16 @@
gl.readBuffer(gl.COLOR_ATTACHMENT0);
wtu.glErrorShouldBe(gl, gl.NO_ERROR,
"calling readBuffer with GL_COLOR_ATTACHMENT0 on fbo should succeed.");
gl.readBuffer(gl.COLOR_ATTACHMENT0 - 1);
wtu.glErrorShouldBe(gl, gl.INVALID_ENUM,
"calling readBuffer with an enum below GL_COLOR_ATTACHMENT0 on fbo should generate INVALID_ENUM.");
shouldBe('gl.getParameter(gl.READ_BUFFER)', 'gl.COLOR_ATTACHMENT0');

var maxColorAttachments = gl.getParameter(gl.MAX_COLOR_ATTACHMENTS);
gl.readBuffer(gl.COLOR_ATTACHMENT0 + maxColorAttachments);
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION,
"calling readBuffer with GL_COLOR_ATTACHMENTi that exceeds MAX_COLOR_ATTACHMENT on fbo should generate INVALID_OPERATION.");
shouldBe('gl.getParameter(gl.READ_BUFFER)', 'gl.COLOR_ATTACHMENT0');
gl.readBuffer(gl.COLOR_ATTACHMENT1);
wtu.glErrorShouldBe(gl, gl.NO_ERROR,
"calling readBuffer with GL_COLOR_ATTACHMENT1 on the fbo should succeed.");
Expand Down
Loading