Kill forked submission processes after execution - #451
Conversation
|
Thanks for the PR. This looks quite heavily like a bot, or at least pure LLM code. So I'm guessing PR comments won't get responses, and I'll close this somewhat swiftly if that seems to be the case. Simon's comments look relevant. Also:
|
|
The updated cleanup now:
I considered killing only the direct PID (leaves forked descendants behind), enumerating descendants manually (racy), and I also tested Ctrl-C against a real Validation on the branch:
|
|
Code style is poor, you resolved multiple comments without actually addressing them. Not wasting time on this bot PR, closing. |
Summary
Closes #450
Validation
.venv/bin/python -m pytest -q tests/test_run_program.py tests/test_run_limit.py— 2 passed.venv/bin/python -m pytest -q --ignore=tests/test_latex.py --ignore=tests/test_markdown.py --ignore=tests/test_xss.py— 67 passed.venv/bin/ruff check ..venv/bin/ruff format --check ..venv/bin/mypy --non-interactive --config-file mypy.ini -p problemtoolsThe full local pytest run additionally needs
lualatex; without it, the first PDF-render test fails and leaves the process in a removed temporary working directory, which cascades into 10 unrelated render-test failures.