Skip to content

Diagram and build tweaks#71

Open
atheken wants to merge 4 commits intoKarnerTh:masterfrom
atheken:diagram-tweaks
Open

Diagram and build tweaks#71
atheken wants to merge 4 commits intoKarnerTh:masterfrom
atheken:diagram-tweaks

Conversation

@atheken
Copy link
Copy Markdown

@atheken atheken commented Dec 4, 2025

  • Allows user to specify "fieldname before type".
  • Enhances make targets to make testing a little bit easier.

- ./mysql/mysql-multiple-databases.sql:/docker-entrypoint-initdb.d/3.sql
mermerd-mssql-test-db:
image: mcr.microsoft.com/mssql/server:2019-latest
platform: linux/amd64
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silences warning on macos

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tweaks allowed me to build/run the tests "out of the box", making it easier to just run make test-unit. At this point, it's probably reasonable to assume docker/docker-compose by default.

@atheken atheken marked this pull request as ready for review December 4, 2025 12:30
@KarnerTh
Copy link
Copy Markdown
Owner

Hi @atheken - appreciate the contribution 🙌🏼

I am not sure if the tool should allow this feature/format though, as the mermaid documentation defines the format as <type> <name> (see here)

According to the docs the two values even have different constraints:

The type values must begin with an alphabetic character and may contain digits, hyphens, underscores, parentheses and square brackets. The name values follow a similar format to type, but may start with an asterisk as another option to indicate an attribute is a primary key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants