Use smaller SI prefixes for low thrust engines#365
Merged
Conversation
dlesbre
force-pushed
the
dlesbre/gui-low-thrust-display
branch
from
8be4174 to
c19a865
Compare
Contributor
|
Perhaps this is better? https://github.com/search?q=org%3AKSP-RO%20printsi&type=code |
Contributor
Author
|
I'm not so sure. Since most engines have thrust in the kN range I think it makes sense to use that prefix as much as possible, even showing values like |
Contributor
|
Then perhaps only switch to the SI method below some number. |
Contributor
Author
|
I've made the change, using PrintSI if the value is outside the 0.01 kN -- 99,999 kN range |
siimav
reviewed
Jul 6, 2026
siimav
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to display thrust in N or mN for low thrust engines in the editor EngineConfig window. At the moment the only engines I could find where this crops up are the ion engines:
I saw ryam suggest this in the RP-1 discord dev-feedback channel and figured I could try my hand at it.