Repository navigation
test: tighten the five Risch difficult-baseline entries the engine now solves - #153
Open
s-celles-bot wants to merge 1 commit into
Open
s-celles-bot wants to merge 1 commit into
s-celles-bot wants to merge 1 commit into
Conversation
…w solves `test/difficult_baseline.jl` asks for engine improvements to tighten its codes. Risch solves entries 3, 26, 27, 49 and 55 and verifies them symbolically against the reference — code 0 — while the baseline still expected code 1, so every `difficult` job printed them as improvements. The five appear in all 9 jobs of the matrix (3 OS x Julia 1.10 / 1 / pre) on both `main` and a current pull request branch, and locally under SymbolicUtils 4.49.0 and 4.50.0 alike, so tightening them is platform-independent. The RuleBased improvements reported alongside are left loose on purpose: the `[6]/[129]/[133]` set and `[132]` improve on almost disjoint sets of platforms, as entry 6's comment already records. Assisted-by: AI
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 50.98% 51.19% +0.21%
==========================================
Files 23 23
Lines 4309 4213 -96
==========================================
- Hits 2197 2157 -40
+ Misses 2112 2056 -56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/difficult_baseline.jlsays "Engine improvements should tighten the codes here on thesame PR." Five Risch entries have been reporting as improvements for a while without being
tightened, so every
difficultjob prints:Risch solves all five and verifies symbolically against the reference, i.e. code 0, where the
baseline still expects code 1. This updates the second element of those five tuples. The gate
is
isempty(regressions), so nothing was failing — but the entries cannot catch a futureregression while they are loose, which is the point of the file.
Evidence that these are platform-independent
The five appear in every
difficultjob, so tightening is safe across the matrix:mainand on acurrent pull request branch;
What this deliberately does not touch
The RuleBased improvements reported alongside them are not platform-independent, so they
stay loose:
[6] (x^2)*sqrt(1 + x)[129] 1 / (-x + x^3)[133] (-3 + x) / (2x + 3(x^2) + x^3)[132] 1 / ((4 - 4x + x^2)*(5 - 4x + x^2))Note that the
[6]/[129]/[133]set and the[132]set are almost disjoint by OS, which iswhat entry 6's existing comment already records ("RB matches reference exactly on Julia 1.10
ubuntu/macOS but produces an equivalent unverifiable form (code 1) on Julia 1.x and
Windows"). Tightening any of them would turn a green matrix red on the other platforms.
Verification
TEST_GROUP=difficultwith the tightened baseline: no regressions, and the five lines aregone from the improvements report. Julia 1.13.0, SymbolicUtils 4.50.0.
Assisted by: AI