Repository navigation
Support JSON.jl v1 - #529
Draft
fromelicks wants to merge 1 commit into
Draft
fromelicks wants to merge 1 commit into
fromelicks wants to merge 1 commit into
Conversation
Allow JSON `1` in `[compat]`. JSON.jl v1 throws on non-finite floats where JSON.jl < 1 wrote `null`, so serialize the kaleido payload through a `JSONStyle` that keeps the old behavior; `NaN` is commonly used for gaps in trace data.
Parse JSON datasets into `Dict{String,Any}` explicitly, since JSON.jl v1 materializes objects as `JSON.Object` by default.
With JSON.jl v1, the Blink, WebIO and JSExpr releases that support it are required as well.
fromelicks
marked this pull request as draft
September 29, 2026 07:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow JSON
1in[compat]. JSON.jl v1 throws on non-finite floats where JSON.jl < 1 wrotenull, so serialize the kaleido payload through aJSONStylethat keeps the old behavior;NaNis commonly used for gaps in trace data. Parse JSON datasets intoDict{String,Any}explicitly, since JSON.jl v1 materializes objects asJSON.Objectby default.With JSON.jl v1, the Blink, WebIO and JSExpr releases that support it are required as well.
Depends on JuliaGizmos/Blink.jl#329, JuliaGizmos/WebIO.jl#521 and JuliaGizmos/JSExpr.jl#49