Skip to content

get_effects() should pull from optimized cache if optimize == true #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
staticfloat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

get_effects() should pull from optimized cache if optimize == true #475

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4986154
`get_effects()` should pull from optimized cache if `optimize == true`
staticfloat Jun 21, 2023
62d458a
Merge branch 'master' into sf/optimized_effects
simeonschaub Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/reflection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function process_info(interp::AbstractInterpreter, @nospecialize(info::CCCallInf
matches = info.results.matches
return mapany(matches) do match::Core.MethodMatch
mi = specialize_method(match)
effects = get_effects(interp, mi, false)
effects = get_effects(interp, mi, optimize)
mici = MICallInfo(mi, rt, effects)
return is_cached(mi) ? mici : UncachedCallInfo(mici)
end
Expand Down