Conversation
| secp256k1_lib_tar='0d9540b13ffcd7cd44cc361b8744b93d88aa76ba' | ||
| secp256k1_lib_sha="0803d2dddbf6dd702c379118f066f638bcef6b07eea959f12d31ad2f4721fbe1" | ||
| secp256k1_lib_tar='f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7' | ||
| secp256k1_lib_sha="bdcb0373cc830271733841cf507ad2bb95d61be558f5334c8ad304d127ee4da9" |
There was a problem hiding this comment.
Verified:
-> ~ wget https://github.com/bitcoin-core/secp256k1/archive/f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.tar.gz
-> ~ sha256sum f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.tar.gz
bdcb0373cc830271733841cf507ad2bb95d61be558f5334c8ad304d127ee4da9 f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.tar.gz
|
Notes on potential things to pay attention; first, these are commits since 99f47c20ec41279075d6b3ae64c9c1a84b40a6f8 Fixes problems with ARM builds(?) identified here. (Very unlikely to matter but just in case this impacts some users of our project). Recent big changes to the Schnorr signing API, clearly not relevant. From Indeed, the only changes I see to the public API are in this PR which implemented Schnorr signing. Also worthy of note is this PR which means ECDH module is no longer considered experimental. Given this I doubt we will see any issues. It may be that the change in removing gmp creates a performance boost, but I don't think it'll be huge so no need to rush moving forward to a version with that, I think. |
Argument why use specific commit of secp256k1 was to have the same version as coincurve uses (https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/536/files#r418937166). Since January coincurve uses
f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.Related - fort-nix/nix-bitcoin#371.