Repository navigation
build(android): bump compile and target SDK to version 36 - #623
Merged
Merged
Conversation
fortuna
added this pull request to stack #624
September 15, 2026 16:57
fortuna
force-pushed
the
build/android-api-36
branch
from
September 15, 2026 16:57
1d1f5b9 to
8c8b54e
Compare
Targets Android 16 (API 36) for Play Store compliance, following the same pattern as the previous bump to API 35 (#603). The app declares no edge-to-edge opt-out, no orientation or resizability restrictions and does not use JobScheduler, so none of the Android 16 targeting behavior changes require code changes. Verified with ./gradlew assembleDebug and ./gradlew test.
fortuna
force-pushed
the
build/android-api-36
branch
from
September 15, 2026 16:58
8c8b54e to
dd65a5b
Compare
The revocation warning used a full-screen intent to jump straight into the main UI. That stopped working long ago: Android 10 restricts background activity starts, and Android 14 only grants USE_FULL_SCREEN_INTENT to calling and alarm apps, so the system downgrades the notification to a heads-up notification. Because no content intent was ever set, the warning could not be tapped at all. Use a content intent instead, which opens the main UI on every supported version and does not need a permission this app is not eligible for. This also resolves the MissingPermission lint error that compileSdk 36 surfaces.
fortuna
added a commit
that referenced
this pull request
Sep 15, 2026
MainActivity overrode onBackPressed() to return to the home view from the settings and info screens. Apps targeting SDK 36 can no longer opt out of predictive back, and the platform now routes back gestures through OnBackPressedDispatcher instead of calling onBackPressed(), so back was leaving the app instead of returning home. Lint flags this as GestureBackNavigation, and only at targetSdk 36 -- the bump in #623 is what introduced the regression. Replace the override with an OnBackPressedCallback registered on the dispatcher. The callback is enabled only while a non-home view is showing, mirroring the existing up-arrow logic in chooseView(), so back still exits the app from the home view. isShowingHomeView() is now unused and removed. This needs androidx.activity 1.6+ to bridge the platform callback; the pinned appcompat 1.4.0 only brings in activity 1.2.4. Upgrade appcompat to 1.7.1, which pulls activity 1.8.0 and still supports minSdk 21. Deliberately not 1.8.0, which would require raising minSdk to 23.
fortuna
added a commit
that referenced
this pull request
Sep 15, 2026
MainActivity overrode onBackPressed() to return to the home view from the settings and info screens. Apps targeting SDK 36 can no longer opt out of predictive back, and the platform now routes back gestures through OnBackPressedDispatcher instead of calling onBackPressed(), so back was leaving the app instead of returning home. Lint flags this as GestureBackNavigation, and only at targetSdk 36 -- the bump in #623 is what introduced the regression. Replace the override with an OnBackPressedCallback registered on the dispatcher. The callback is enabled only while a non-home view is showing, mirroring the existing up-arrow logic in chooseView(), so back still exits the app from the home view. isShowingHomeView() is now unused and removed. This needs androidx.activity 1.6+ to bridge the platform callback; the pinned appcompat 1.4.0 only brings in activity 1.2.4. Upgrade appcompat to 1.7.1, which pulls activity 1.8.0 and still supports minSdk 21. Deliberately not 1.8.0, which would require raising minSdk to 23.
fortuna
added a commit
that referenced
this pull request
Sep 15, 2026
MainActivity overrode onBackPressed() to return to the home view from the settings and info screens. Apps targeting SDK 36 can no longer opt out of predictive back, and the platform now routes back gestures through OnBackPressedDispatcher instead of calling onBackPressed(), so back was leaving the app instead of returning home. Lint flags this as GestureBackNavigation, and only at targetSdk 36 -- the bump in #623 is what introduced the regression. Replace the override with an OnBackPressedCallback registered on the dispatcher. The callback is enabled only while a non-home view is showing, mirroring the existing up-arrow logic in chooseView(), so back still exits the app from the home view. isShowingHomeView() is now unused and removed. This needs androidx.activity 1.6+ to bridge the platform callback; the pinned appcompat 1.4.0 only brings in activity 1.2.4. Upgrade appcompat to 1.7.1, which pulls activity 1.8.0 and still supports minSdk 21. Deliberately not 1.8.0, which would require raising minSdk to 23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the Android build to API level 36 (Android 16):
This mirrors #603 (the 34 -> 35 bump), which was also a
gradle.properties-only change.Why no code changes are needed
I went through the Android 16 behavior changes that apply to apps targeting SDK 36
and checked each against this app:
windowOptOutEdgeToEdgeEnforcement) removedandroid:fitsSystemWindows="true".screenOrientation,resizeableActivityormaxAspectRatio.JobSchedulerquotasJobScheduler.Verification
Run locally with JDK 17 and SDK platform 36 / build-tools 36.0.0:
./gradlew assembleDebug— BUILD SUCCESSFUL (Go backend AAR rebuilt viagomobile bind)./gradlew test— BUILD SUCCESSFULFollow-ups, now handled elsewhere in the stack
Bumping compileSdk to 36 surfaced one new lint error,
MissingPermissionforUSE_FULL_SCREEN_INTENTon the VPN-revoked notification. That turned out to be a realbug rather than just a lint complaint, and is fixed in the second commit here.
AGP 8.5.1 also warned that it was only tested up to compileSdk 34. That is fixed by
#626, which upgrades AGP to 9.4.0.
Note that
./gradlew lintDebugalready fails onmasterwith three pre-existingerrors (
StartActivityAndCollapseDeprecated,RestrictedApi,QueryAllPackagesPermission). This PR does not add to them. CI only runsgo test.