Skip to content

Make getMethodHandlesImplLookup Handle Exceptions #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alonalbert wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

Make getMethodHandlesImplLookup Handle Exceptions #3481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions java/debugger/impl/src/com/intellij/debugger/engine/MethodInvokeUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ object MethodInvokeUtils {
}

fun getMethodHandlesImplLookup(evaluationContext: EvaluationContextImpl): ObjectReference? {
val theClass = evaluationContext.debugProcess.findClass(evaluationContext,
"java.lang.invoke.MethodHandles\$Lookup",
null)
val theField = DebuggerUtils.findField(theClass,
"IMPL_LOOKUP")
return theClass?.getValue(theField) as? ObjectReference
val theClass = runCatching {
// On Android API < 26, this will throw
evaluationContext.debugProcess.findClass(evaluationContext, "java.lang.invoke.MethodHandles\$Lookup", null)
}.getOrNull() ?: return null
Copy link
Copy Markdown

@cursor cursor bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runCatching silently swallows cancellation exceptions

Medium Severity

Using runCatching here catches all Throwable instances, including ProcessCanceledException and CancellationException, which are used by the IntelliJ Platform for task cancellation. Swallowing these causes the method to return null instead of propagating the cancellation signal, potentially leaving the IDE in an unresponsive or inconsistent state when the user cancels an evaluation. A try/catch that rethrows cancellation exceptions would be appropriate here.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1c2b159. Configure here.

val theField = DebuggerUtils.findField(theClass, "IMPL_LOOKUP")
return theClass.getValue(theField) as? ObjectReference
}
}

Expand Down