Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
...in/jvm-debugger/testFramework/testSrc/org/jetbrains/kotlin/idea/debugger/test/ArtAttacher.kt
Show resolved
Hide resolved
alonalbert
force-pushed
the
update-art-attacher
branch
from
3634728 to
c4f901b
Compare
* Add cache for dexed classes to reduce test run time. * Register some extensions that allow more tests to pass. * Attach the list of DEX files to the project as user data.
alonalbert
force-pushed
the
update-art-attacher
branch
from
c4f901b to
6c3632c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the ART-based debugger test launcher to build and cache per-classpath DEX artifacts and to register Android-specific debugger extensions; this can affect test correctness and stability due to caching, reflection-based D8 invocation, and new extension point wiring.
Overview
Speeds up ART VM debugger tests by switching from a single temp DEX build to per-dependency DEX generation with an optional on-disk cache (controlled by
INTELLIJ_DEBUGGER_TESTS_DEX_CACHE/intellij.debugger.tests.dex.cache), using a hash-based filename and atomic moves.The ART attacher now registers Android-specific extensions (
AndroidDexerandFieldVisibilityProvider) for the test session and stores the produced DEX paths in project user data viaDexBytecodeInspector.DEX_FILES_KEYto enable dex-aware inspections during debugging.Build/test module metadata is updated to include required Android and JDOM test dependencies.
Written by Cursor Bugbot for commit 6c3632c. This will update automatically on new commits. Configure here.