[JEWEL-1290] DefaultBanner Should not Hardcode Padding#3466
Open
DanielSouzaBertoldi wants to merge 2 commits intoJetBrains:masterfrom
Open
[JEWEL-1290] DefaultBanner Should not Hardcode Padding#3466DanielSouzaBertoldi wants to merge 2 commits intoJetBrains:masterfrom
DanielSouzaBertoldi wants to merge 2 commits intoJetBrains:masterfrom
Conversation
DanielSouzaBertoldi
force-pushed
the
dsb/JEWEL-1290
branch
from
72ef3d0 to
4178268
Compare
DanielSouzaBertoldi
force-pushed
the
dsb/JEWEL-1290
branch
from
4178268 to
62537ef
Compare
DanielSouzaBertoldi
force-pushed
the
dsb/JEWEL-1290
branch
from
62537ef to
ba52bb4
Compare
daaria-s
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is a direct continuation of #3390 , so for this PR just take a look at
DefaultBanner.kt,Banners.ktandSwingComparisonTabPanel.ktContext
DefaultBannerhas a default padding value of10.dp. This PR changes it to use whatever is set instyle.metrics.paddinginstead. It also stops filling the entire available width and instead just wraps its content.Changes
.padding(10.dp)to.padding(style.metrics.padding)in the Row that wraps the banner content..width(IntrinsicSize.Max)to theColumnthat wraps the banner content.Release notes
*DefaultBannerno longer fills the available width by default; it now wraps its content instead. If you want banners to span the full width, be sure to addmodifier = Modifier.fillMaxWidth().Bug fixes
*DefaultBannercomponents are now customizableScreenshots