[PY-73290] Fix missing deprecation warnings for property setters#3448
Open
unclepomedev wants to merge 1 commit intoJetBrains:masterfrom
Open
[PY-73290] Fix missing deprecation warnings for property setters#3448unclepomedev wants to merge 1 commit intoJetBrains:masterfrom
unclepomedev wants to merge 1 commit intoJetBrains:masterfrom
Conversation
PyDeprecationInspection now identifies assignments to properties where the corresponding setter is marked as deprecated, including those defined in type stubs.
unclepomedev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/PY-73290, https://youtrack.jetbrains.com/issue/PY-57000
What this PR does:
PyDeprecationInspectionnow identifies assignments to properties where the corresponding setter is marked as deprecated, including those defined in type stubs (.pyi).Implementation details:
visitPyTargetExpressionto correctly resolve property setters and identify deprecation warnings when a property is assigned a value.AccessDirection.WRITEproperty accessor, ensuring setter-only deprecations in.pyifiles are accurately detected.Testing:
PyDeprecationTest.java.Screenshots:
Shows the inspection correctly highlighting an assignment to a deprecated setter in the Blender API (
bpy) stubs.