Expose externalProjectPath on ExternalSystemNotificationExtension.customize()#2427
Closed
vmadalin wants to merge 1 commit intoJetBrains:masterfrom
Closed
Conversation
Member
|
Hi! @vmadalin I cannot merge this pull request. There are a lot of compilation and usages conflicts.
Please fix it and attach minimized Android commits. |
a075b77 to
ebc1939
Compare
Contributor
Author
|
Hi @HackerMadCat, thank you for reviewing the changes. I'm adding an update about them:
Seems you are referring to https://github.com/pantsbuild/intellij-pants-plugin but definitely there are more plugins that may be affected by this. However, I marked the method as deprecated but also with empty implementation avoiding to require implementation by default
I created the following PR JetBrains/android#24 that resolving android conflicts on your android fork |
ebc1939 to
8deb2dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added to be able to support multiple gradle root projects, providing the
externalProjectPathon theExternalSystemNotification.customizeallowing to provide better error message to users