Skip to content

fix(security): use Replace-based newline stripping in SanitizeLogValue #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerrettDavis merged 1 commit into from
Jun 23, 2026
Merged

fix(security): use Replace-based newline stripping in SanitizeLogValue #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/Core/PokManager.Domain/Common/SafePath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,17 @@ public static string SanitizeLogValue(string? value)
return string.Empty;
}

var builder = new System.Text.StringBuilder(value.Length);
foreach (var c in value)
// Use String.Replace to strip line breaks (recognized as a log-forging barrier),
// then drop any remaining control characters.
var withoutNewlines = value
.Replace("\r", string.Empty, StringComparison.Ordinal)
.Replace("\n", string.Empty, StringComparison.Ordinal)
.Replace("\t", " ", StringComparison.Ordinal);

var builder = new System.Text.StringBuilder(withoutNewlines.Length);
foreach (var c in withoutNewlines)
{
builder.Append(c is '\r' or '\n' ? '_' : char.IsControl(c) ? ' ' : c);
builder.Append(char.IsControl(c) ? ' ' : c);
}

return builder.ToString();
Expand Down
Loading