Fix PEP 695 ParamSpec crashes - #519
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P.argsandP.kwargswhen a PEP 695ParamSpecis represented internally as an input signature__type_params__metadata from protocol requirementsRoot cause
PEP 695 ParamSpecs use pycroscope's canonical
InputSigValuerepresentation directly, while several older paths expected runtime partial-call or ordinary gradual values. Attribute lookup and generic subscripting consequently sent these non-gradual values throughreplace_fallback()or gradual assignability. Constructor specialization also treated flat ParamSpec arguments as scalar types instead of single-parameter callable signatures.The protocol mismatch was separate: runtime PEP 695 classes expose
__type_params__, and pycroscope was accidentally including that metadata in structural protocol members.The full conformance suite was run against the exact head of python/typing#2215. It now reports no internal errors and matches the updated known-failure list.
The floating taxonomy check exposed additional non-crashing findings in newly pushed taxonomy code. Those are addressed by taxonomy#83, whose pycroscope workflow passes; the currently red third-party check on this PR predates that follow-up.