chore(renovate): let Renovate see the tests workspace - #466
Open
jahia-carp wants to merge 1 commit into
Open
Conversation
config:recommended extends :ignoreModulesAndTests, whose ignorePaths holds **/tests/**, so Renovate never read tests/package.json or tests/yarn.lock. The Cypress dependencies of this repository were therefore never proposed for an update, and a bump PR that looked complete only touched the root lockfile. The override keeps node_modules out and drops the rest, which is what Jahia/javascript-modules already does: Renovate updates its tests workspace, this one it could not.
1 task
🦜 ChachalogNo changelog entries detected. Learn more about Chachalog. Create a new entry online or run |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renovate never read
tests/package.jsonortests/yarn.lockin this repository, so the Cypress dependencies were never proposed for an update. This adds one line to.github/renovate.jsonto make that directory visible again.Why
.github/renovate.jsonextendsconfig:recommended. That preset extends:ignoreModulesAndTests, whoseignorePathsis:tests/is a separate Yarn project here, with its ownpackage.json, its own lockfile and its ownpackageManager. It is not one of the root workspaces, which arepackages/*. The pattern**/tests/**therefore hides the whole Cypress project from Renovate.Two bump requests show the effect.
Jahia/luxe-jahia-demo#450andJahia/luxe-jahia-demo#465each raise@jahia/cypressin the rootyarn.lockalone. Neither changes what the Cypress suite resolves, and a reader who trusts the title reads the repository as updated when the tests are not.Changes
One line:
"ignorePaths": ["**/node_modules/**"].This keeps
node_modulesout and drops the other patterns, which none of this repository's directories needs.Jahia/javascript-modulescarries exactly this override, and Renovate updates itstests/workspace:Jahia/javascript-modules#721is one of those updates.Effect
Renovate will propose updates for
tests/package.jsonfrom now on. The first run after this merges may open one pull request per outdated@jahia/*dependency of that workspace, because none was ever proposed. ThepackageRulesof this file already restrict Renovate to@jahia/*, so the volume is bounded by that list.Validation
The file parses as JSON. The behaviour itself is only observable after the merge, in Renovate's next run and in the Dependency Dashboard issue.
No changelog fragment: the change is limited to the repository's own tooling, with no user-visible impact.