ci: drop the on-code-change inputs the shared workflow now derives - #732
Merged
Conversation
jahia-modules-action v2.65.0 derives the triggering ref, the Sonar comparison branch, the artifact prefix and the standalone test run, and defaults the audit level, the Jahia image and the TestRail skip to what this repository declared.
🦜 ChachalogNo changelog entries detected. Learn more about Chachalog. Create a new entry online or run |
commit: |
Contributor
Author
|
The CI passed (https://github.com/Jahia/javascript-modules/actions/runs/32498998540?pr=732), merging it |
baptistegrimaud
marked this pull request as ready for review
August 21, 2026 16:15
baptistegrimaud
added
the
🗒️ no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the seven inputs jahia-modules-action#405 made unnecessary, released in v2.65.0. Eleven inputs become four:
build_container_imagestays because this repository builds on JDK 17, where the shared default is 11.Dropped because the workflow derives them
module_branch,sonar_analysis_primary_release_branch,integration_tests_standalone_execute.Dropped because the value is now the default
static_analysis_auditci_level(critical),integration_tests_jahia_image(ghcr.io/jahia/jahia-ee-dev:8-SNAPSHOT),integration_tests_should_skip_testrail(true).Dropped because it never did anything
integration_tests_should_use_build_artifactsis deprecated and ignored — build artifacts are downloaded whenever they exist.One visible change
Test artifacts are renamed from
standalone-tests-<run>tostandalone-javascript-modules-engine-<run>: the prefix now comes frommodule_id. No workflow file in the organisation references the old name.This exact caller already ran green against the change before it merged, in the throw-away #726 (run 32485354032), integration tests included. That pull request is now redundant and can be closed.