Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: JS server extension points, client-callable actions, and the JSServerExtensionInvoker SDK #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: JS server extension points, client-callable actions, and the JSServerExtensionInvoker SDK #687
Changes from 10 commits
d2551107b3ffd928c97828c5eeff3c93a15ece86fb32cec5c3b6c507777bc316469897e1f6ce7b7930aff3508e5075a37e5008239517fd5d9778c8376631bb7c5be889685263c0cdca73b02d043fb73a7f4ec857f7115f52eb1a588f5d7e60da4649b9ef4480dac3ee179984a8be437439d5200f7487fb3e7c81caf758cb7cffccb20c2435b4020d12e5ed13File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation seems a bit underwhelming, there's not much we can do in there:
What goals do we have with choicelist initializers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely despise the design, I get why it exists but it means content modeling can spread across three file types:
This is the wrong solution to the right problem: CND validation sucks
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.