Skip to content

feat: expose react-dom - #522

Merged
GauBen merged 2 commits into
mainfrom
feat/expose-react-dom
Oct 15, 2025
Merged

GauBen merged 2 commits into
mainfrom
feat/expose-react-dom

Conversation

@GauBen

@GauBen GauBen commented Oct 7, 2025 •

Copy link
Copy Markdown
Member

Description

We only expose react-dom/client but some common JS dependencies import react-dom: e.g. floating-ui.

Expose react-dom to reduce duplication in client code, and possibly bugs (because libraries that embed their version may create inconsistencies)

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

Copilot AI review requested due to automatic review settings October 7, 2025 08:29
@GauBen
GauBen requested a review from a team as a code owner October 7, 2025 08:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the react-dom module to reduce duplication in client code and prevent potential inconsistencies when libraries embed their own versions of react-dom.

  • Added a new shared module file that re-exports specific functions from react-dom
  • Updated both client and server library configurations to include the new react-dom mapping

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
javascript-modules-engine/src/shared/react-dom.ts Creates a new shared module that re-exports selected react-dom functions
javascript-modules-engine/shared-libs.mjs Adds react-dom mapping to both client and server library configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread javascript-modules-engine/src/shared/react-dom.ts
@GauBen
GauBen force-pushed the feat/expose-react-dom branch from 335e9be to deec8a1 Compare October 8, 2025 12:09
@GauBen
GauBen merged commit bf145de into main Oct 15, 2025
9 checks passed
@GauBen
GauBen deleted the feat/expose-react-dom branch October 15, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants