Repository navigation
feat: expose react-dom - #522
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the react-dom module to reduce duplication in client code and prevent potential inconsistencies when libraries embed their own versions of react-dom.
- Added a new shared module file that re-exports specific functions from react-dom
- Updated both client and server library configurations to include the new react-dom mapping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| javascript-modules-engine/src/shared/react-dom.ts | Creates a new shared module that re-exports selected react-dom functions |
| javascript-modules-engine/shared-libs.mjs | Adds react-dom mapping to both client and server library configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GauBen
force-pushed
the
feat/expose-react-dom
branch
from
October 8, 2025 12:09
335e9be to
deec8a1
Compare
baptistegrimaud
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We only expose
react-dom/clientbut some common JS dependencies importreact-dom: e.g. floating-ui.Expose
react-domto reduce duplication in client code, and possibly bugs (because libraries that embed their version may create inconsistencies)Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review