Acorn spack-stack v2 updates - #1791
Merged
AlexanderRichert-NOAA merged 18 commits intoOct 22, 2025
Merged
AlexanderRichert-NOAA merged 18 commits into
AlexanderRichert-NOAA merged 18 commits into
Conversation
climbfuji
reviewed
Oct 9, 2025
AlexanderRichert-NOAA
marked this pull request as ready for review
October 9, 2025 18:03
Collaborator
|
I'll wait for the CI tests to pass, thanks for the chained env bug fixes. |
climbfuji
approved these changes
Oct 10, 2025
…H so it can find rustc
Collaborator
Author
|
A couple final tweaks. Any future updates will be a separate PR. |
climbfuji
reviewed
Oct 10, 2025
AlexanderRichert-NOAA
requested review from
Hang-Lei-NOAA,
RatkoVasic-NOAA,
eap and
rickgrubin
October 20, 2025 21:47
Hang-Lei-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
It takes a long time to read the copilot review. But its concerns are all about the impact on other platforms, after a carefully reading. Copilot is trying to optimize it to a universal frame not considering the specific settings for acorn.
I am going to try it on Acorn.
AlexanderRichert-NOAA
enabled auto-merge
October 21, 2025 19:19
Hang-Lei-NOAA
approved these changes
Oct 22, 2025
AlexanderRichert-NOAA
disabled auto-merge
October 22, 2025 17:02
AlexanderRichert-NOAA
merged commit Oct 22, 2025
ab957f9
into
JCSDA:feature/update_to_spack_v1
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Dependencies
none
Issues addressed
Related to #1772
Related to #1604
Applications affected
UFS WM, GW, misc. EMC
Systems affected
Acorn
Testing
Checklist
doc/source/PreConfiguredSites.rstanddoc/source/MaintainersSection.rst