Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34.
No Solidity contracts, authorization rules, package versions, lockfile, or network configuration are changed.
Verification
Environment: Node 20.19.0, pnpm 9.15.9, Hardhat 2.22.8, ethers 6.13.2, fhevm 0.5.8 and fhevmjs 0.5.2. Tests ran with the public
.env.exampleconfiguration and--network hardhatinside a network namespace; no live network was used.contract runner does not support calling.pnpm test:mock --grep 'Quality authorized view|ConfidentialERC20Wrapper': 4 passing, including wrap and asynchronous unwrap.pnpm test:mock: 12 passing, 2 failing. The remaining two compliance tests now reach the ACL check and fail withUser is not authorized to reencrypt this handle!; this exposes the separate sender-balance contract ACL issue already addressed by open PR fix: grant contract ACL permission on sender's new balance in CompliantConfidentialERC20._transfer #32. It is deliberately not included in this helper-only change.git diff --cached --check: passed.Existing limitations
pnpm lint:tscstill reports the existingcoprocessorUtils.tserrors and undeclaredweb3-validatortype resolution. No new diagnostic appears in the added test or provider-binding changes.fhevmTempfiles; those generated files are not part of this PR.