Skip to content

[#442] Only create cache directory if disk cache is enabled & minor fixes#443

Merged
Ingrim4 merged 4 commits into
masterfrom
442-only-create-cache-dir-if-enabled
Aug 21, 2025
Merged

[#442] Only create cache directory if disk cache is enabled & minor fixes#443
Ingrim4 merged 4 commits into
masterfrom
442-only-create-cache-dir-if-enabled

Conversation

@Ingrim4

@Ingrim4 Ingrim4 commented Aug 21, 2025

Copy link
Copy Markdown
Member

Description

  • Only create the disk cache directory if the disk cache is enable by value.
  • Fix possible NPE when the modrinth API returned a non 200 status code or an empty body.
  • Migrate from repo.dmulloy2.net to maven central

Related Issue

closes #442

Motivation and Context

Reduce creation on unused directories if possible.

How Has This Been Tested?

Successfully tested with latest Paper release.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

NgLoader
NgLoader previously approved these changes Aug 21, 2025
@Ingrim4 Ingrim4 changed the title [#442] Only create cache directory if disk cache is enabled [#442] Only create cache directory if disk cache is enabled & minor fixes Aug 21, 2025
@Ingrim4 Ingrim4 merged commit afa027f into master Aug 21, 2025
1 check passed
@Ingrim4 Ingrim4 deleted the 442-only-create-cache-dir-if-enabled branch September 7, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not create cache folder if caching is disabled

2 participants