Skip to content

Add support for choice on canvases#82

Merged
jamesmisson merged 7 commits intomainfrom
choice
Apr 23, 2026
Merged

Add support for choice on canvases#82
jamesmisson merged 7 commits intomainfrom
choice

Conversation

@jamesmisson
Copy link
Copy Markdown
Collaborator

This PR adds support for choices on canvases, following on from IIIF-Commons/manifesto#173.

The Helper now has:

  • choiceIndex to track choice state
  • hasChoices
  • getActiveChoice
  • getChoices

And tests for the IIIF cookbook manifest.

I'll leave this in draft for now as it should be tested with a manifest with multiple canvases with choice.

@jamesmisson jamesmisson requested a review from demiankatz April 8, 2026 10:08
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Apr 8, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jamesmisson, and sorry it has taken me a couple of days to get back to you. See below for a couple of comments. Regarding the versioning piece, we've been pretty inconsistent about semantic versioning in the past, so a minor misstep here is not a disaster, but we should aim to be more consistent in future!

Comment thread package-lock.json
Comment thread src/Helper.ts Outdated
@jamesmisson
Copy link
Copy Markdown
Collaborator Author

Thanks for the review @demiankatz , I've made the recommended changes

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jamesmisson, looks good to me! You still have this in draft mode, so I won't merge it yet... but feel free to take out of draft and merge if you're done!

@jamesmisson jamesmisson marked this pull request as ready for review April 23, 2026 08:46
@jamesmisson jamesmisson merged commit 4e457cf into main Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants