Add 'get' canvas functions to ranges#79
Open
MImranAsghar wants to merge 4 commits intoIIIF-Commons:mainfrom
Open
Add 'get' canvas functions to ranges#79MImranAsghar wants to merge 4 commits intoIIIF-Commons:mainfrom
MImranAsghar wants to merge 4 commits intoIIIF-Commons:mainfrom
Conversation
MImranAsghar
commented
Nov 23, 2020
- Add getCanvases, getCanvasById, getCanvasByIndex functions for the range type
d0e842d to
53830e3
Compare
Member
|
I'm not sure why, but 3 tests appear to be failing now: |
Author
|
Ah interesting, looking into it 👍 |
53830e3 to
87399d8
Compare
Author
|
Hi @stephenwf , fixed the tests |
- Create getCanvases, getCanvasById, getCanvasByIndex functions for the range type
sequence to range as well - Add test for getCanvasById range
... index to each canvas in range
87399d8 to
2bd289b
Compare
... ranges when getting canvases
2bd289b to
53a2e81
Compare
Author
|
Hi @stephenwf , I was wondering if you got a chance to take a look at the changes. do you think this can be merged? 🤔 |
Member
|
Sorry yes I think so 👍 @edsilv ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.