Particle weights are now stored using the global normalization - #670
Conversation
# Conflicts: # CHANGELOG.rst
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #670 +/- ##
===========================================
+ Coverage 79.26% 79.46% +0.20%
===========================================
Files 142 142
Lines 8386 8415 +29
Branches 1116 1122 +6
===========================================
+ Hits 6647 6687 +40
+ Misses 1366 1358 -8
+ Partials 373 370 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # pyabc/distance/pnorm.py # pyabc/inference/smc.py # pyabc/visualization/walltime.py
# Conflicts: # pyabc/inference_util/inference_util.py
|
Wait for #668 to be merged before |
# Conflicts: # CHANGELOG.rst # pyabc/storage/migrations/versions/2_20260724_add_populations_wall_time.py
|
Ready to be merged when test pass |
kilianvolmer
left a comment
kilianvolmer
left a comment
There was a problem hiding this comment.
Thank you for resolving this old issue. The changes look fine, but I would like to see a test for the database conversion. Could you please add that?
kilianvolmer
left a comment
kilianvolmer
left a comment
There was a problem hiding this comment.
Thank you for implementing all the changes! I think we can merge this now :)
3 participants
I took the chance that #668 changes the database anyway to resolve the old issue #47. Particle weights are now stored using the global normalization (weights sum to 1 across all particles of all models, matching the in-memory
Populationrepresentation). This is bundled into database version 2 and handled byabc-migratefor existing databases.Moreover, the PR cleans up some more type hints, solves some minor bugs across the codebase and adds some more tests.