Tag commits whose images land on stable channels#179
Open
johnshaughnessy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag commits whose docker images are given the
stablechannel/tag (e.g.hubs.stable-1234.2022-11-29), so that git users can easily see which commits are associated with shipped images.The run number is the unique id (that is also used in the docker tag).
The date is not as important, but added for convenience / human readability. (It is also not unique, if we deploy twice in a day).
This PR only tags commits that land in the stable channels. It might be useful to also add tags for beta channels, but starting with just the stable builds for now since those are more likely to be the artifacts we care about during an audit.
We discussed that it may be useful have a git tag called
hubs.stable-latest, but changing the commit that a tag points to is an operation that you have to--forcein git. I think that also means that anyone who wants local copies of the github repo's tags will also get warnings / conflicts whenever they try to pull. So I think the happy path will be to not have ahubs.stable-latestgit tag.