-
Notifications
You must be signed in to change notification settings - Fork 4
[Bug]: gempyor.distributions Configuration Consistency #603
Copy link
Copy link
Open
Labels
bugDefects or errors in the code.Defects or errors in the code.configRelating to configuration files or their framework.Relating to configuration files or their framework.gempyorConcerns the Python core.Concerns the Python core.low priorityLow priority.Low priority.quick issueShort or easy fix.Short or easy fix.
Description
Activity
Metadata
Metadata
Assignees
Labels
bugDefects or errors in the code.Defects or errors in the code.configRelating to configuration files or their framework.Relating to configuration files or their framework.gempyorConcerns the Python core.Concerns the Python core.low priorityLow priority.Low priority.quick issueShort or easy fix.Short or easy fix.
Label
bug, config, gempyor, quick issue
Priority Label
low priority
Describe the bug/issue
Several of the distributions describe the same kinds of parameters with different names for backwards compatibility reasons. For example the
NormalDistributionusesmu&sigmafor location and scale whereasTruncatedNormalDistributionusesmeanandsd. And similarly for the upper and lower for uniform and truncated normal. This can be addressed by making a choice for the internal name that we want to use for these parameters and then supporting user preferred names withpydanticaliases.To Reproduce
N/A
Environment, if relevant
MacOS 15.6, Python 3.11.13, R 4.3.3, Conda 24.5.0, Git 2.50.1, Branch dev