Skip to content

sapling: migrate to python@3.13 #273239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
branchv wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

sapling: migrate to python@3.13 #273239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Formula/s/sapling.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
depends_on "libssh2"
depends_on "node"
depends_on "openssl@3"
depends_on "python@3.12" # Python 3.13 issue: https://github.com/facebook/sapling/issues/980
depends_on "python@3.13"

uses_from_macos "llvm" => :build # for libclang
uses_from_macos "bzip2"
Expand Down Expand Up @@ -92,7 +92,7 @@
odie "Inreplace did not modify any branch usage in Cargo.toml manifests!" if no_modification
end

python3 = "python3.12"
python3 = "python3.13"
ENV["LIBSSH2_SYS_USE_PKG_CONFIG"] = "1"
ENV["OPENSSL_DIR"] = Formula["openssl@3"].opt_prefix
ENV["PYTHON_SYS_EXECUTABLE"] = which(python3)
Expand All @@ -107,7 +107,7 @@
system "make", "-C", "eden/scm", "install-oss", "PREFIX=#{prefix}", "PYTHON=#{python3}", "PYTHON3=#{python3}"
end

test do

Check failure on line 110 in Formula/s/sapling.rb

View workflow job for this annotation

GitHub Actions / macOS 14-arm64

`brew test --verbose sapling` failed on macOS Sonoma (14) on Apple Silicon! 

==> Testing sapling
==> /opt/homebrew/Cellar/sapling/0.2.20260317-201835/bin/sl --version
(see https://sapling-scm.com/ for more information)
==> /opt/homebrew/Cellar/sapling/0.2.20260317-201835/bin/sl config --user ui.username Sapling <sapling@sapling-scm.com>
SystemError: null argument to internal routine
Fatal Python error: _PyImport_InitExternal: external importer setup failed
Python runtime state: core initialized

Current thread 0x00000001f052d0c0 (most recent call first):
  <no Python frame>
::error::sapling: failed
An exception occurred within a child process:
  BuildError: Failed executing: /opt/homebrew/Cellar/sapling/0.2.20260317-201835/bin/sl config --user ui.username Sapling\ <sapling@sapling-scm.com>
/opt/homebrew/Library/Homebrew/formula.rb:3473:in 'block in Formula#system'
/opt/homebrew/Library/Homebrew/formula.rb:3409:in 'IO.open'
/opt/homebrew/Library/Homebrew/formula.rb:3409:in 'Formula#system'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Formula#_on_method_added'
/opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/s/sapling.rb:111:in 'block in <class:Sapling>'
/opt/homebrew/Library/Homebrew/formula.rb:3195:in 'block (3 levels) in Formula#run_test'
/opt/homebrew/Library/Homebrew/extend/kernel.rb:230:in 'Kernel#with_env'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Kernel#_on_method_added'
/opt/homebrew/Library/Homebrew/formula.rb:3194:in 'block (2 levels) in Formula#run_test'
/opt/homebrew/Library/Homebrew/formula.rb:1434:in 'Formula#with_logging'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Formula#_on_method_added'
/opt/homebrew/Library/Homebrew/formula.rb:3193:in 'block in Formula#run_test'
/opt/homebrew/Library/Homebrew/mktemp.rb:97:in 'block in Mktemp#run'
/opt/homebrew/Library/Homebrew/mktemp.rb:97:in 'Dir.chdir'
/opt/homebrew/Library/Homebrew/mktemp.rb:97:in 'Mktemp#run'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Mktemp#_on_method_added'
/opt/homebrew/Library/Homebrew/formula.rb:3535:in 'Formula#mktemp'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::M

Check failure on line 110 in Formula/s/sapling.rb

View workflow job for this annotation

GitHub Actions / Linux arm64

`brew test --verbose sapling` failed on Linux arm64! 

/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/4.0.1/bin/bundle 
==> Testing sapling
==> /home/linuxbrew/.linuxbrew/Cellar/sapling/0.2.20260317-201835/bin/sl --version
SystemError: null argument to internal routine
Fatal Python error: _PyImport_InitExternal: external importer setup failed
Python runtime state: core initialized

Current thread 0x0000ff11c60eb020 (most recent call first):
  <no Python frame>

::error::sapling: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected: 0
  Actual: 1
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/minitest-6.0.2/lib/minitest/assertions.rb:176:in 'Minitest::Assertions#assert'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/minitest-6.0.2/lib/minitest/assertions.rb:216:in 'Minitest::Assertions#assert_equal'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_assertions.rb:29:in 'Homebrew::Assertions#assert_equal'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Homebrew::Assertions#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_assertions.rb:43:in 'Homebrew::Assertions#shell_output'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Homebrew::Assertions#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/s/sapling.rb:109:in 'block in <class:Sapling>'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3195:in 'block (3 levels) in Formula#run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/kernel.rb:230:in 'Kernel#with_env'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Kernel#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3194:in 'block (2 levels) in Formula#run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:1434:in 'Formula#with_logging'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.12997/lib/types/private/methods/_methods.rb:259:in 'block in Formula#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:
require "utils/linkage"

assert_equal "Sapling #{version}", shell_output("#{bin}/sl --version").chomp
Expand Down
Loading