Skip to content

fix(curation,dataset): query check_runs_latest in coverage and dataset SQL #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kstonekuan merged 2 commits into from
Oct 4, 2026
Merged

fix(curation,dataset): query check_runs_latest in coverage and dataset SQL #678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ca7af
fix(curation,dataset): query check_runs_latest in coverage and datase…
k0shir0 Oct 3, 2026
06bf4bc
add replay error regression tests, clarify latest check results
k0shir0 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hflow/curation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ def _collect_coverage(connection: duckdb.DuckDBPyConnection) -> tuple[int, list[
coverage_rows = connection.execute(
f"""
SELECT check_name, count(DISTINCT episode_id) AS episodes_ran
FROM check_runs WHERE status IN ({status_list})
FROM check_runs_latest WHERE status IN ({status_list})
AND episode_id IN (SELECT episode_id FROM episodes_latest)
GROUP BY check_name ORDER BY check_name
"""
Expand Down
2 changes: 1 addition & 1 deletion src/hflow/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def default_dataset_sql(application: "App") -> str:
)
predicates.append(
"episode_id IN (\n"
" SELECT episode_id FROM check_runs\n"
" SELECT episode_id FROM check_runs_latest\n"
f" WHERE status IN ({settled_statuses})\n"
f" AND ({identity_clauses})\n"
" GROUP BY episode_id\n"
Expand Down
Loading