Repository navigation
fix(transform): preserve declared empty camera channels - #654
harshitethic wants to merge 3 commits into
Conversation
|
👋 Hi @harshitethic — thanks for the contribution! To keep starter issues available You already have #651 open, so this one is being closed automatically. |
|
| for source_channel_id in sorted(infos, key=lambda cid: (infos[cid].topic, cid)): | ||
| info = infos[source_channel_id] | ||
| if source_channel_id in camera_payloads: |
There was a problem hiding this comment.
Empty camera breaks media step
When a source declares an empty camera, this change adds it to Episode.cameras. The built-in contact-sheet step then calls Episode.frames() for it. Episode.video() raises because there are no timestamps to estimate a frame rate, so the media step fails. Keep the declaration, but skip cameras with no frames when making contact sheets.
Summary
This keeps camera handling consistent with the existing rule that a declared channel is present even when it is empty, and prevents distinct source declarations from collapsing to the same canonical representation.
Fixes #528.
Testing
Focused regression coverage is included in tests/test_transform.py. Tests were not executed through this GitHub connector session.