Repository navigation
Conversation
The library already supported running a curation query without writing a manifest (output=None), but the CLI offered no way to reach it. Add --dry-run mutually exclusive with --output, and make CurationReport.summary() render the None case as '(not written; dry run)' instead of the literal string 'None'. Closes Hebbian-Robotics#8
Contributor
|
👋 Thanks @ayam04 — the implementation quality here is genuinely good. However, we accept one "good first issue" PR per contributor at a time, so that these starter issues stay available for other new contributors and each PR gets a real review. Of your seven PRs we kept #18 open (the strongest and most substantive one) and are closing the rest, including this one. The underlying issue is open again for anyone to pick up. Once #18 is merged you are very welcome to bring one of these back — and for larger contributions beyond the good-first-issue pool, feel free to open as many focused PRs as you like after discussing in an issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Two curation rough edges:
hflow curate --dry-run(mutually exclusive with--output) now reaches the library's existingoutput=Nonepath: the query runs (row count + coverage reported) but nothing is written.CurationReport.summary()renders the None case as(not written; dry run)instead of the literalNone.Tests:
None--dry-run+--outputrejected by argparseValidation:
uv run pytest tests/test_catalog_curation.py -qpasses.