Skip to content

Added 5 Unity classes + Fix X-mirroring of models #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added 5 Unity classes + Fix X-mirroring of models #103

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e01aae1
Add 3 colliders
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz Jun 19, 2021
4865694
Add 3 colliders
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz Jun 19, 2021
b47696f
Add MeshRenderer & reduce code
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz Jun 19, 2021
b953aa4
Add MeshFilter
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz Jun 19, 2021
e529954
Fix x-mirroring of models
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz Jul 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unitypack/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def read(self, buf):
return self

def __str__(self):
return "%s %s %s" % (-self.x, self.y, self.z)
return "%s %s %s" % (self.x, self.y, self.z)


class OBJVector4(OBJVector3):
Expand Down Expand Up @@ -147,7 +147,7 @@ def __init__(self, mesh):
@staticmethod
def face_str(indices, coords, normals):
ret = ["f "]
for i in indices[::-1]:
Copy link
Copy Markdown
Contributor

@robert-nix robert-nix Jul 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was done to convert from left-handed coordinates to right-handed coordinates, FWIW. So without this the face normals would all be inside out in tools that expect right-handed models.

Copy link
Copy Markdown
Author

@j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz Jul 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, um, TBH I thought pull requests would only add the commits from before they were made.
Either way, you are correct, however removing the - on line 31 inverts the models once, so the face normals are as they should.
I know it's a bit counter-intuitive but if you test it, it should be fine.

for i in indices:
ret.append(str(i + 1))
if coords or normals:
ret.append("/")
Expand Down