Open
Conversation
Does the same as the fast version of the outline but does it cardinally instead of diagonally You could also consider it being a variant of OUTLINE_FAST. I dont know if it were to be a good idea renaming OUTLINE_FAST into OUTLINE_DIAGONAL because of perhaps many projects using it But it would definitely be a possibility
|
God this is so fucking hot. |
|
WE NEED THIS!!!!! |
Geokureli
reviewed
Apr 19, 2026
Comment on lines
+1301
to
+1305
| final i = delta * (iter + 1); | ||
| func(-i, 0); // middle-left | ||
| func(i * 2, 0); // middle-right | ||
| func(-i, -i); // upper-middle | ||
| func(0, i * 2); // lower-middle |
Member
There was a problem hiding this comment.
Still need to test this locally, but I'm surprised by i*2 and upper middle being -i, -i. Looking at OUTLINE_FAST I would have expected the following
Suggested change
| final i = delta * (iter + 1); | |
| func(-i, 0); // middle-left | |
| func(i * 2, 0); // middle-right | |
| func(-i, -i); // upper-middle | |
| func(0, i * 2); // lower-middle | |
| final i = delta * (iter + 1); | |
| func(-i, 0); // left | |
| func( i, 0); // right | |
| func( 0, -i); // up | |
| func( 0, i); // down |
Author
There was a problem hiding this comment.
That's definitely a mistake on my end
i did not realize that FlxBitmapText seems to absolute instead of incremental like FlxText
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works like the fast outline method, but uses cardinal directions instead of diagonals. This generally looks better for pixelated fonts.
You could also treat this as a variant of
OUTLINE_FAST. RenamingOUTLINE_FASTtoOUTLINE_DIAGONALmight make things clearer, but it could break existing projects, so it’s probably not worth changing.OUTLINE_FAST (diagonal)
OUTLINE_CARDINAL
OUTLINE (the normal one)