Rename all TODOs to HACKERSM64_DO - #927
Conversation
The TODO keyword should really be reserved for actual ROM hackers, as most of them probably couldn't care less about any HackerSM64 or decomp tech debt. Searchability for the TODO keyword, as well as HACKERSM64_DO and DECOMP_DO should also be a lot easier now, with fewer irrelevant results.
|
wait you guys unironically search for the TODO comments that you left? i thought it was a bit |
|
Believe it or not, yes (especially in hacks) |
|
don't agree with this one |
|
What do you propose instead? I really do not want to leave messy TODOs in this repo (particularly not ones that obfuscate search results and standardized syntax highlighting) |
|
First of all I don't think that there's any point in distinguishing between base decomp vs hackersm64 todos - decomp is not in development anymore, so either we decide if we want to do those todos ourselves, making them a hackersm64 todo, or we just delete them. Second this would just encourage us to never address the todos. Regardless its not a blocker for 2.4 |
|
But mainly I just think this introduces potential merge conflicts for upgrades for no good benefit/reason which I dont like |
|
Deleting the comments would also create conflicts, but none of them are of any difficulty to fix. I would be open to deleting most of the decomp ones since yeah I agree irrelevant, but I think it's worth keeping some hacker ones in some manner. Either way though I still want those TODOs gone since it's a hindrance for people that actually use that keyword (most programmers) |
|
i think you heavily overestimate the number of people who actively use todo and also expect it to be easily searchable. i mean we clearly don't even do that, and we're the ones leaving the todos |
|
For what it's worth, this has frustrated me before. Freeing up TODO for child projects would be nice for those that would use it. I don't think Arctic is overestimating the use of TODO as a keyword, seeing as it's commonly given its own syntax highlighting rules in code editors/IDEs. |
|
Yeah us not addressing the TODOs isn't because they're useless, it's because we're lazy lol (although the repo being 90% decomp TODOs doesn't help either) |
The TODO keyword should really be reserved for actual ROM hackers, as most of them probably couldn't care less about any HackerSM64 or decomp tech debt. Searchability for the TODO keyword should now be uninhibited by former TODOs, as they now read HACKERSM64_DO.