Split camera.c - #827
Open
someone2639 wants to merge 35 commits into
Open
Conversation
added 19 commits
August 9, 2024 16:49
added 6 commits
August 28, 2024 17:43
Collaborator
Author
|
I believe this PR is ready for initial review. As always, the README has the intended file structure in case there are comments on that. Things to consider:
|
Collaborator
|
i see a TODO in the PR description so either do it or update the description if its outdated... |
Collaborator
Author
|
updated |
arthurtilly
reviewed
Jan 30, 2025
arthurtilly
reviewed
Jan 30, 2025
Collaborator
Author
|
ready for another lap 🏇 (resolved merge conflicts, this is the camera PR not the crash screen one) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


camera.c 11148 ->
31782441 linesSee README for details on file structure
TODO's for the PR:Decide on whether it's worth adding a file for camera shake and camera sound(Decided not worth by popular vote)