Conversation
…ation The design as implemented in the GridTools/gt4py stack #2898, #2899, #2907-#2912 (ADRs 0028, 0029): corrected concepts and sketch, binding model, shared local dimensions, answered open questions, the PR stack, and where the implementation departs from the original proposal.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the connectivities as types note (#32) to the design as implemented in the GridTools/gt4py stack:
GridTools/gt4py#2898 → #2899 → #2907 → #2908 → #2909 → #2910 → #2911 → #2912 (ADR 0028: dimensions as nominal types; ADR 0029: connectivities as types).
What changed in the note
DimensionBaseIndex, andLocalDimensionIndexsubclassesDimensionIndexNeighborConnectivityis not aConnectivityoffset_tagnames a connectivity in the IRC2CE)MultiDimensionIndexis a tuple subclassas_offset(KDim, field)resolvememoizes (so redefined declarations are found), the interactive-__main__fallback, the narrowcopyreghook forStaggered[D], fingerprinting, the corrected injective mangling (the original scheme was not injective), and a new rule onoffset_tag.ts.OffsetType,iterator.runtime.offsetand the string-keyed providers below the entry points are kept.dependent-local-dimensionsis still open.statusstaysdraft: this was written with AI assistance and needs a human review.