feat: sse-events with vanguard#508
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies to their latest versions and integrates a forked version of vanguard-go to enable Server-Sent Events (SSE) streaming support. The changes address the limitation where the standard Vanguard library blocks streams via REST.
- Updated multiple dependencies including connect, validate, vanguard, and various other packages to their latest versions
- Replaced the official vanguard package with a custom fork that supports SSE streaming
- Modified server configuration to enable REST Server-Sent Events for the thread service
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tim-api/internal/server/server.go | Updated validate interceptor initialization and enabled SSE for thread service |
| tim-api/go.mod | Updated dependencies and replaced vanguard with custom fork supporting SSE |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ) | ||
|
|
||
| replace ( | ||
| connectrpc.com/vanguard => github.com/joroshiba/vanguard-go v0.0.0-20250930221328-b9a1ff0dc494 |
There was a problem hiding this comment.
Using a personal fork with a pseudo-version (v0.0.0-...) creates dependency maintenance risks. Consider creating a proper release tag in the fork or submitting the SSE changes upstream to the official vanguard repository for better long-term maintainability.
| connectrpc.com/vanguard => github.com/joroshiba/vanguard-go v0.0.0-20250930221328-b9a1ff0dc494 | |
| connectrpc.com/vanguard => github.com/joroshiba/vanguard-go v0.1.0 |
|
Note, I have opened a PR into the upstream: connectrpc/vanguard-go#176 |
| if err != nil { | ||
| return err | ||
| } | ||
| validateInterceptor := validate.NewInterceptor() |
There was a problem hiding this comment.
Is it fine to not check this err?
There was a problem hiding this comment.
With the latest version of vanguard, there is no error returned by the new operator
joroshiba
force-pushed
the
joroshiba/sse-vanguard
branch
from
8d8a486 to
e51019f
Compare
Summary
Updates to some dependencies which weren't at latest, and updates vanguard-go to utilize a fork I have created enabling SSE streams.
Background
Vanguard blocks streams via REST.
Issues
closes GRE-252