feat(go): support go 1.26 and delve 1.26.1#149
feat(go): support go 1.26 and delve 1.26.1#149patrickpichler wants to merge 1 commit intoGoogleContainerTools:duct-tapefrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to upgrade the Go version to 1.26 and Delve to 1.26.1 across the helper image, Skaffold configuration, and integration tests. However, multiple critical issues were identified because Go 1.26 and Delve 1.26.1 are not currently existing or valid versions. These changes will cause the Docker build to fail as the base images and source archives cannot be retrieved. The feedback recommends using a valid Go version, such as 1.25 or a patch update for 1.24, and updating all associated test manifests and labels accordingly.
| @@ -1,10 +1,10 @@ | |||
| ARG GOVERSION=1.24 | |||
| ARG GOVERSION=1.26 | |||
There was a problem hiding this comment.
Go version 1.26 is not a valid or existing version. The current stable release is 1.24. This will cause the build to fail as the base image golang:1.26 cannot be pulled.
| ARG TARGETARCH | ||
|
|
||
| ARG DELVE_VERSION=1.24.1 | ||
| ARG DELVE_VERSION=1.26.1 |
There was a problem hiding this comment.
Delve version 1.26.1 does not exist (current versions are ~1.24.x). The build will fail at line 19 when attempting to download the source archive from GitHub.
| context: test/goapp | ||
| docker: | ||
| buildArgs: | ||
| GOVERSION: '1.26' |
There was a problem hiding this comment.
Using Go version 1.26 here is inconsistent with available Go releases and skips version 1.25. If the intention was to add the next supported version, it should likely be 1.25 or a patch update for 1.24.
| # This test approximates `skaffold debug` for a go app. | ||
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| name: go126pod | ||
| labels: | ||
| app: hello | ||
| protocol: dlv | ||
| runtime: go126 |
There was a problem hiding this comment.
The naming convention and labels throughout this file use go126, which corresponds to the non-existent Go version 1.26. This file should be updated to reflect a valid Go version.
1 participant
Same as #147 , but with support for Golang 1.26