Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating
PyJWTto2.12.0is necessary for security, but the current codebase has issues that will prevent it from working correctly after this update:jwt.encode: Iniap/generate_self_signed_jwt.py(line 101), a JSON string is passed tojwt.encode.PyJWT2.x requires the payload to be adictorbytes. Passing astr(as returned bygenerate_jwt_payload) will raise aTypeError. Thegenerate_jwt_payloadfunction should be refactored to return a dictionary for this usage.iap/generate_self_signed_jwt.pyimportsiam_credentials_v1, which requires thegoogle-cloud-iam-credentialspackage. This package is missing fromrequirements.txt(thegoogle-cloud-iampackage on line 8 is separate and does not include this module).Please address these issues to ensure the sample remains functional.