feat(firestore): pipeline queries snippets#5506
feat(firestore): pipeline queries snippets#5506grayside merged 7 commits intoGoogleCloudPlatform:mainfrom
Conversation
product-auto-label
Bot
added
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of Go code snippets demonstrating Firestore pipeline features, including aggregations, array operations, logical expressions, and vector functions. It also adds a corresponding test suite and updates the system test configuration with a new environment variable. Review feedback highlights the need for robust error handling during document writes by using batch operations and emphasizes the importance of closing the Firestore client to prevent resource leaks.
|
Hi @amcolin, I have updated all the pipeline snippets to follow this pattern by printing the error message to the provided io.Writer before returning the error. This ensures they are idiomatic for samples and maintain compatibility with our test suite. |
amcolin
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
amcolin
left a comment
amcolin
left a comment
There was a problem hiding this comment.
Everything looks great! I really appreciate the attention to detail on the error handling. Solid approval from me.
|
Kokoro build failures are for packages not related to the changes in this PR. It passes for Firestore. |
5 participants
Description
This PR contains Firestore pipline queries snippets. These are 1:1 line conversions from Java's existing PipelineSnippets.java and new ones from googleapis/java-firestore#2365
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)Create a enterprise edition Firestore in Native mode database in test project named 'db-enterprise-01'