Skip to content

chore: Adding erlanderlo as dataflow maintainers #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guilherme-hosoda-cit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Adding erlanderlo as dataflow maintainers #3409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/terraform/test-org/org/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ locals {
org = "terraform-google-modules"
description = "Handles opinionated Dataflow job configuration and deployments"
topics = local.common_topics.da
maintainers = local.adc_common_admins
maintainers = concat(["erlanderlo"], local.adc_common_admins)

@gemini-code-assist gemini-code-assist Bot May 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When combining lists where uniqueness is desired, use setunion() instead of concat() to automatically handle and prevent duplicate entries.

      maintainers = setunion(["erlanderlo"], local.adc_common_admins)
References
  1. When combining lists where uniqueness is desired, use setunion() instead of concat() to automatically handle and prevent duplicate entries.

@guilherme-hosoda-cit guilherme-hosoda-cit May 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to make this modification? I understand its purpose, but using concat is standard in this file.

@guilherme-hosoda-cit guilherme-hosoda-cit May 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this value is used to define a value for a set variable, that already removes duplicated entries.

lint_env = {
ENABLE_BPMETADATA = "1"
}
Expand Down
Loading