providers/gcp: generalize async op handling into GcloudCommand.IssueAsync#6803
Closed
ashishsuneja wants to merge 8 commits into
Closed
providers/gcp: generalize async op handling into GcloudCommand.IssueAsync#6803ashishsuneja wants to merge 8 commits into
ashishsuneja wants to merge 8 commits into
Conversation
added 8 commits
June 9, 2026 12:47
- _IssueAsync: issues gcloud --async commands, returns op name - CreateNodePoolAsync: creates nodepool, returns op handle - DeleteNodePoolAsync: deletes nodepool, returns op handle - UpgradeNodePoolAsync: upgrades nodepool, returns op handle - UpdateClusterAsync: toggles label for non-destructive update - WaitForOperation: polls until DONE/ABORTING - ResolveNodePoolVersions: auto-detects initial/target versions - _GetLatestOperationName: fallback op lookup by type+target - GetNodePoolNames: lists current node pools Tested: - Existing GKE test suite passing - pyink + lint-diffs clean
…sueAsync; add tests
…sync Moves the --async issue + 'no op name printed, fall back to listing operations' pattern out of GKE-specific _IssueAsync into a reusable GcloudCommand.IssueAsync method, with the resource-specific lookup (_GetLatestOperationName for GKE) passed in as a callable. Per hubatish's review on PR GoogleCloudPlatform#6747.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #6747 per hubatish's review comments (#6747 (comment)... and the seconding comment below it).
Moves the
--asyncissue + 'no op name printed, fall back to listing operations' pattern out of GKE-specific_IssueAsyncinto a reusableGcloudCommand.IssueAsyncmethod on the shared GCP util class, with the resource-specific lookup (_GetLatestOperationNamefor GKE) passed in as an optionalget_latest_op_fncallable.Scope: Purely additive —
GcloudCommand.Issue()itself is unchanged, so none of the 194 existing call sites across GCP providers are affected.Tested:
GoogleKubernetesEngineAsyncOpsTestCasetests passtests/providers/gcp/suite: 278/281 passed (3 failures are pre-existing test-isolation flakiness ingce_managed_instance_group_test.py/gcp_cluster_test.py, unrelated to this change — confirmed they fail identically without this patch applied)