Skip to content

kubernetes_management: add benchmark + base cluster management plane methods #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishsuneja wants to merge 16 commits into
base: master
Choose a base branch
from
+1,459 −31
Open

kubernetes_management: add benchmark + base cluster management plane methods #6746

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c30c6ba
kubernetes_management: add benchmark + base cluster management plane …
Jun 5, 2026
6bdc03e
kubernetes_management: address review (config anchor, Prepare docstri…
Jun 9, 2026
c959389
kubernetes_management: descriptive scenario names, grouped flags, sce…
Jun 9, 2026
bf8c1d1
kubernetes_management: split out upgrade path — create/delete only
Jun 9, 2026
b0c04ec
kubernetes_management: purge A/B/C naming, extract helpers, separate …
Jun 10, 2026
0e1dba3
kubernetes_management: sweep node pools after each scenario instead o…
Jun 10, 2026
620fd56
kubernetes_management: condense changelog, document _OpResult fields,…
Jun 10, 2026
e2a106f
kubernetes_management: remove BaseEksCluster AddNodepool no-op stub (…
Jun 12, 2026
17df7f8
kubernetes_management: fail-hard by default, tolerant large_scale; Op…
Jun 12, 2026
f431c3f
kubernetes_management: rename scale->goal_nodepools (nit 334)
Jun 12, 2026
6e38531
kubernetes_management: split large_scale_provisioning into a follow-u…
Jun 18, 2026
9562498
kubernetes_management: address review feedback (round 3)
Jun 23, 2026
5662918
kubernetes_management: move changelog entry under New features section
Jun 29, 2026
2957606
Merge branch 'master' into mgmt_plane_benchmark_base
ashishsuneja Jun 29, 2026
1f36225
container_service_mock: implement GetNodePoolNames on TestKubernetesC…
Jun 29, 2026
15ee9b3
provision_container_cluster_benchmark_test: implement GetNodePoolName…
Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
### New features:

@hubatish hubatish Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an existing new features section below. Add to there.
Other comments:

  • Just one line about adding the benchmark is likely sufficient for all the PRs.
  • No need for author credit (PR history shows this)
  • No need to specify "add abstract methods" - again probably the whole PR stack can be summarized into a couple bullet points.

@ashishsuneja ashishsuneja Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — moved it into the existing new-features section, collapsed to a single line, and dropped both the author credit and the abstract-methods bullet.

- Add kubernetes_management benchmark for measuring GKE/EKS/AKS management

@hubatish hubatish Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a new features section below which is where this should go.

@ashishsuneja ashishsuneja Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — turns out the entry was under a stale "New features" header at the top of the file; moved it into the actual current section further down (with the Ubuntu 26.04 / MySQL sysbench entries).

plane API responsiveness. (from @ashishsuneja)
- Add KubernetesCluster base class management plane abstract methods:
CreateNodePool, DeleteNodePool, UpgradeNodePool, UpdateCluster and
their async counterparts. (from @ashishsuneja)

### Breaking changes:

- Added --accept_licenses flag. User have to turn this flag on to acknowledge
Expand Down
Loading