-
Notifications
You must be signed in to change notification settings - Fork 244
params.Frame: Add parameters for 3-D plots #4594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seisman
wants to merge
12
commits into
main
Choose a base branch
from
codex/frame-3d-modifiers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−2
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5234400
Add 3-D Frame modifiers
seisman e7fe391
Improve docstrings and simplify tests
seisman eed7a64
Fix one test
seisman 4139d51
Fix the order
seisman d749ab7
Fix the oder
seisman 0c712dc
Merge branch 'main' into codex/frame-3d-modifiers
seisman a1c72ce
Merge branch 'main' into codex/frame-3d-modifiers
seisman faad739
Merge branch 'main' into codex/frame-3d-modifiers
seisman 53035e3
Merge branch 'main' into codex/frame-3d-modifiers
seisman a71462a
Merge branch 'main' into codex/frame-3d-modifiers
seisman 48c5507
Clarify that fill can be overridden by xyfill/yzfill/xzfill
seisman 20bc060
Fix styling
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe if all three of
yzfill,xzfillandxyfillare used,fillwill not have an effect.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
fillsets the fill of the three back-faces but can be overridden byyzfill/xzfill/xyfill. We need to improve the docstring to clarify it.Actually, as a non-native English speaker, I don't know the standard terminology to describe the elements of a cube. Currently, we describe them as "frontground lines", "outlines of x-z and y-z planes", "yz-plane"/"xz-plane"/"xy-plane", but it seems in standard terminology, they should be called faces (front face? back face?), and edges.